-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bin, Idf, Uf2 support to cargo flash #1765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for looking into this!
I added two comments :)
I would add a new error type at least for when the UF2 file does not have a loadable section. The conversion from usize to u32 can stay an unwrap imo :)
I am fine using your UF2 crate if you intend to maintain it. If it ever changes, we can easily take maintainership :)
Thank you for your quick review! |
I am pretty much good to merge this after the open question is resolved we can undraft and get this merged :) |
I'm going to do a small second release of uf2 crate ahead of this PR being ready. |
Not sure why |
This reverts commit 12865b7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
#1758
This is very rough so far. In trying to add UF2 support to cargo flash, it helped to bring across some stuff that was only available on probe-rs so far ie. Bin and Idf support. Is this desirable?
I've 'cheated' with errors for now through
unwrap
. Should I create more error types or useanyhow
? For now I've just deleted a now unused error type. 44d69bfdbec2d768aa388dbb3f142b3b7cb033afI've used my own crate for UF2 but I'm not married to it. I haven't evaluated other options very well yet and my crate does not have very good support for multiple sections.