-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update defmt_decoder #2167
Update defmt_decoder #2167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We do! What would make it easier for you? |
That's great! However, the library is currently marked as follows: //! This is an implementation detail of [`probe-run`](https://github.com/knurling-rs/probe-run) and
//! not meant to be consumed by other tools at the moment so all the API is unstable. In my opinion this is not a very friendly guarantee (or, lack thereof), especially when the internals are tied to an archived/deprecated project :) From my personal POV, defmt has been around unstably for long enough without much change and probably without huge need for change. In my opinion it's time to start moving down the 1.0 route, or at least to offer some better-then-nothing guarantees for incorporating crates into third party host software. All I'd like to see is probe-rs to not break if a new defmt_decoder is released. This issue also affects Since we now have the library pinned to Sorry if this got a bit rant-y. |
No worries. I get the point.
To be honest it was not a very conscious decision to keep the API unstable. It was more of a case of "it works for us", so we didn't bother stabilizing it. And a small nit: the I will raise the topic internally. |
Closes #2153
Closes #2155
knurling/ferrous really doesn't want us using defmt_decoder, so I'm open to alternatives