make init macros accept expr for $size, path for $mode
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yatekii
reviewed
Nov 22, 2023
Yatekii
reviewed
Nov 22, 2023
Co-authored-by: Noah Hüsser <noah@huesser.dev>
Yatekii
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
rtt_init_print!()macro didn't really usertt_target::ChannelModeenums. Users can be confused of thertt_init_print!(BlockIfFull, 1024)syntax, that user won't able usertt_init_print!(ChannelMode::BlockIfFull, 1024), and when theyimport rtt_target::ChannelMode::*, compiler said it's a unused import.So, this PR make init macros accept
$mode:path, which let user usertt_init_print!(ChannelMode::BlockIfFull, 1024)etc.Also, this PR make
$size:expr, which let users writertt_init_print!(ChannelMode::BlockIfFull, 2usize.pow(10)).And this PR is a breaking change, which require users add comma
,at the end of each line of each channel ofrtt_init!()macro (which make the syntax more like creating a regular struct).