-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle binary in extension #60
Comments
See also https://github.com/microsoft/vscode-platform-specific-sample for an example. |
@Tiwalun Quite a few people I know of, use this extension with By bundling the binary, would we add complications for those use cases? |
Not really, we can just have a configurable setting where you can choose the bundled binary or a different one. Or you use the existing mode where you connect over tcp. |
Fair. We have existing config settings in |
I had a look at the examples included above, and cannot see how to get from their 'dependency' on a node package that includes the platform executables, to our own cargo release of the binaries. For now, I will leave this enhancement for someone else to attempt, with this final note: The extension currently supports the |
cargo dist supports npm packages, so it might be quite easy to get this: https://opensource.axo.dev/cargo-dist/book/installers/npm.html |
But it seems we could also place a binary in the extension directory, and then bundle it. That might be easier than using a complete other package. |
I'm guessing it is safe to assume we have a binary for each of the VSCode supported platforms? |
It's possible to bundle binaries in a vscode extension, and this can be done in a platform specific way. See https://code.visualstudio.com/api/working-with-extensions/publishing-extension#platformspecific-extensions
It would be nice to bundle the debugger binary, so that users don't have to install a separate tool.
The text was updated successfully, but these errors were encountered: