Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup casino_training.ipynb #36

Closed
murphyk opened this issue Jun 24, 2022 · 1 comment · Fixed by #45
Closed

cleanup casino_training.ipynb #36

murphyk opened this issue Jun 24, 2022 · 1 comment · Fixed by #45
Assignees

Comments

@murphyk
Copy link
Member

murphyk commented Jun 24, 2022

Currently https://github.com/probml/ssm-jax/blob/main/ssm_jax/hmm/demos/casino_training.ipynb
relies to hmm_fit_minibatch, should change to hmm_fit_sgd

@murphyk
Copy link
Member Author

murphyk commented Jun 25, 2022

Also, modify code so that EM gives results like the old JSL code

Screen Shot 2022-06-24 at 5 10 15 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants