Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor hmm/models.py #60

Closed
murphyk opened this issue Jul 1, 2022 · 0 comments · Fixed by #61
Closed

refactor hmm/models.py #60

murphyk opened this issue Jul 1, 2022 · 0 comments · Fixed by #61
Assignees

Comments

@murphyk
Copy link
Member

murphyk commented Jul 1, 2022

Our hmm/models.py is getting too big. We could just use that for BaseHMM and factor out each subclass into its own file, so we would have ar_hmm.py, gaussian_hmm.py, categorical_hmm.py, poisson_hmm etc. This is more modular since we can encapsulate model-specific logic (eg M step) into separate files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants