Linear regression code includes calls to missing functions

[thvasilo]

In examples like linregPolyVsDegree.py there are calls to a preprocessor_create function which seems to be part of an old version of utils.util but has since been removed.

I guess we should bring back some of those functions to get the examples working again?

[murphyk]

Sure. Or better yet, re-do these examples using scikit learn, whcih
supports a lot of these preprocessors already.
(No need to re-invent the wheel.)

On Fri, Oct 28, 2016 at 2:03 AM, Theodore Vasiloudis <
notifications@github.com> wrote:

Files like linregPolyVsDegree.py there are calls to a preprocessor_create
function which seems to be part of an old version
https://github.com/drgnrave/pmtk3/blob/76c1174447f262a30acda7345816d2956c18919c/python/utils/util.py#L79
of utils.util but has since been removed.

I guess we should bring back some of those functions to get the examples
working again?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#13, or mute the thread
https://github.com/notifications/unsubscribe-auth/AEavEMQDrjlApOF1ERygdWYAWc8RKHiyks5q4bp-gaJpZM4KjOhS
.

[thvasilo]

Cool, I'm in favor of using sklearn where possible as well.

I'll get this done this week.

On Oct 29, 2016 9:59 PM, "Kevin P Murphy" notifications@github.com wrote:

Sure. Or better yet, re-do these examples using scikit learn, whcih
supports a lot of these preprocessors already.
(No need to re-invent the wheel.)

On Fri, Oct 28, 2016 at 2:03 AM, Theodore Vasiloudis <
notifications@github.com> wrote:

Files like linregPolyVsDegree.py there are calls to a preprocessor_create
function which seems to be part of an old version
<https://github.com/drgnrave/pmtk3/blob/76c1174447f262a30acda7345816d2
956c18919c/python/utils/util.py#L79>
of utils.util but has since been removed.

I guess we should bring back some of those functions to get the examples
working again?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#13, or mute the thread
<https://github.com/notifications/unsubscribe-auth/
AEavEMQDrjlApOF1ERygdWYAWc8RKHiyks5q4bp-gaJpZM4KjOhS>
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#13 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AIoTo72ggn3Rpkn_kf-3hXLtnZf8EbMuks5q46WigaJpZM4KjOhS
.

[murphyk]

linregPolyVsDegree.py now works. It still relies on utils.util and is not yet based on scikit-learn. It would be great to remove depenence on utils.util...