Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHKF plots to ekf_vs_ukf.ipynb #1083

Merged
merged 4 commits into from Jul 27, 2022
Merged

Add GHKF plots to ekf_vs_ukf.ipynb #1083

merged 4 commits into from Jul 27, 2022

Conversation

petergchang
Copy link
Contributor

Description

Added GHKF plots to ekf_vs_ukf.ipynb.

Figure Number

book2 - 8.12

Figures

ghkf_source ghkf_target

Issue

#1082

Checklist

  • Performed a self-review of the code
  • Tested on Google Colab.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@murphyk
Copy link
Member

murphyk commented Jul 27, 2022

Can you please make helper functions

(m,S,C) = ukf.transform(non_linear_transform, mean_pre, cov_pre)
(m,S,C) = ghkf.transform(non_linear_transform, mean_pre, cov_pre)

that wraps up some of the low level logic (I think you can reuse https://github.com/probml/ssm-jax/blob/main/ssm_jax/ggssm/containers.py#L61).
Something like this:

Screen Shot 2022-07-27 at 12 39 49 PM

I realize that you may also want to return the transformed sigma points, for plotting, so these
could be optional return args.

@murphyk murphyk merged commit 6201373 into probml:master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants