-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latexified and Jaxified Fig 11.1, Fig 11.4, Fig 11.19 mcmc_gmm_demo.ipynb
| Book2
#891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
nipunbatra
reviewed
Jun 2, 2022
LGTM. But please respond to @nipunbatra 's comments. |
I've made changes as per suggested by Prof. @nipunbatra. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
notebooks/book2/11/mcmc_gmm_demo.ipynb
latexify()
on 3D figures, due to very lessfig_height
, So I have done some workarounds and partially applylatexify()
to 3D figures.Figure Number
Book2, Chapter-11
Fig 11.1
Fig 11.4
Fig 11.19
Figures
1. Fig 11.1
Before PR
![image](https://user-images.githubusercontent.com/59387624/171476300-6884b037-409a-4d6a-a45a-f895e3078fe8.png)
After PR
![image](https://user-images.githubusercontent.com/59387624/171476187-805c9628-d788-4576-b54f-6a2dc1d776aa.png)
2. Fig 11.4
3. Fig 11.19
Before PR
![image](https://user-images.githubusercontent.com/59387624/171475668-85b4ed4b-da25-4e1f-8b48-519d67142b78.png)
After PR
![image](https://user-images.githubusercontent.com/59387624/171475841-481ed998-c0d7-4edf-9e03-dd8ccef94aac.png)
Issue
#890
Steps
Checklist
cc - Dr. @murphyk, Prof. @nipunbatra