Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latexified and Jaxified Fig 11.1, Fig 11.4, Fig 11.19 mcmc_gmm_demo.ipynb | Book2 #891

Merged
merged 11 commits into from
Jun 2, 2022
Merged

Conversation

karm-patel
Copy link
Collaborator

@karm-patel karm-patel commented Jun 1, 2022

Description

  • Latexified and Jaxified notebooks/book2/11/mcmc_gmm_demo.ipynb
  • Generally, it is hard to apply latexify() on 3D figures, due to very less fig_height, So I have done some workarounds and partially apply latexify() to 3D figures.

Figure Number

Book2, Chapter-11
Fig 11.1
Fig 11.4
Fig 11.19

Figures

1. Fig 11.1

  • Before PR
    image

  • After PR
    image

2. Fig 11.4

  • Before PR
    image
  • After PR
    image

3. Fig 11.19

  • Before PR
    image

  • After PR
    image

Issue

#890

Steps

  • Jaxified
  • Latexifed the figure
  • Followed PEP8 naming convention

Checklist

  • Performed a self-review of the code
  • Tested on Google Colab.

cc - Dr. @murphyk, Prof. @nipunbatra

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

notebooks/book2/11/mcmc_gmm_demo.ipynb Show resolved Hide resolved
notebooks/book2/11/mcmc_gmm_demo.ipynb Show resolved Hide resolved
notebooks/book2/11/mcmc_gmm_demo.ipynb Show resolved Hide resolved
notebooks/book2/11/mcmc_gmm_demo.ipynb Show resolved Hide resolved
notebooks/book2/11/mcmc_gmm_demo.ipynb Show resolved Hide resolved
notebooks/book2/11/mcmc_gmm_demo.ipynb Show resolved Hide resolved
notebooks/book2/11/mcmc_gmm_demo.ipynb Show resolved Hide resolved
@murphyk
Copy link
Member

murphyk commented Jun 2, 2022

LGTM. But please respond to @nipunbatra 's comments.

@karm-patel
Copy link
Collaborator Author

I've made changes as per suggested by Prof. @nipunbatra.

@murphyk murphyk merged commit fac2727 into probml:master Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants