Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fig_name to Fig_height mapping #896

Merged
merged 1 commit into from Jun 4, 2022
Merged

Add Fig_name to Fig_height mapping #896

merged 1 commit into from Jun 4, 2022

Conversation

karm-patel
Copy link
Collaborator

@karm-patel karm-patel commented Jun 4, 2022

Description

  • Added a table containing fig_name & fig_height. (fig_height_book1.md, fig_height_book2.md).
  • This mapping would be useful for contributors while doing latexifying tasks. They can give the exact height (in latexify()) of the figure given in latex source code, so there are fewer chances of compressing the image (e.g. 3in figure to 1.5in)
  • However TexSoup is not able to read 48 .tex files from total of 607 tex files. I kept a list of these files in internal/fig_height/tex_defective.txt Later we can handle these files using pure regex scrapping.

I'll link these .md file to dashboard #739 once this PR gets merged.

Issue

Task 8 of #862

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@murphyk murphyk merged commit 3d8c2b4 into probml:master Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants