Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Common readme file #932

Merged
merged 11 commits into from Jun 26, 2022
Merged

Added Common readme file #932

merged 11 commits into from Jun 26, 2022

Conversation

karm-patel
Copy link
Collaborator

@karm-patel karm-patel commented Jun 25, 2022

Description

  • Added common_readme.md which contains notebook_name, colab link and github link

I am enlisting advantages of having this file just for recap:

  1. Now we don't need firestore redirection, so adding a new notebook would be easy.
  2. We don't need duplicate notebooks in separate folders which point to the root notebook.
    • Currently, we can remove book2 duplicate notebooks, but not book1 to maintain backward compatibility.
  3. We don't need dummy notebooks like fig_10_9.ipynb anymore.
    • Again we can remove fig_x_y.ipynb from book2, but not book1
  • There were some notebooks with identical content or either of them latexified and other is not. I've updated all such notebooks such that we will have only a single root notebook and other notebooks would have pointers to this root notebook.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@karm-patel karm-patel changed the title Added Common readme file [WIP] Added Common readme file Jun 25, 2022
@karm-patel
Copy link
Collaborator Author

karm-patel commented Jun 25, 2022

Dr. @murphyk, in which directory you will suggest putting common_readme.md?

@murphyk murphyk merged commit fd57697 into probml:master Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants