Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement UKF #111

Merged
merged 13 commits into from Jul 19, 2022
Merged

Implement UKF #111

merged 13 commits into from Jul 19, 2022

Conversation

petergchang
Copy link
Collaborator

@petergchang petergchang commented Jul 18, 2022

Description

  • Unscented Kalman filter is implemented as unscented_kalman_filter() in ukf/inference.py.
  • Unscented Kalman smoother is implemented as unscented_kalman_smoother() in ukf/inference.py.
  • Pendulum and spiral demos are implemented in ukf/demos/ukf_pendulum.py, ukf/demos/ukf_spiral.py.

Progress

  • Despite the visual verification of the ukf results in ukf/demos, the filtered/smoothed results seem to non-trivially diverge from those of sarkka-jax library. I am in the process of inspecting the cause of the incongruency.
    ukf_pendulum
    uks_pendulum
    ukf_spiral

Issue

#63

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@petergchang petergchang marked this pull request as ready for review July 19, 2022 18:08
@murphyk murphyk merged commit bfcb40a into probml:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants