Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LFO Delay and LFO Key Sync no function #526

Closed
Banana71 opened this issue Aug 5, 2023 · 10 comments
Closed

LFO Delay and LFO Key Sync no function #526

Banana71 opened this issue Aug 5, 2023 · 10 comments

Comments

@Banana71
Copy link

Banana71 commented Aug 5, 2023

No matter what value you set for the LFO Delay (TG1 -TG8), the LFO starts working immediately without delay. The same goes for LFO Key Sync.

_

LFO Delay Introduces a delay between the time at which a key is pressed and the time at which the Low Frequency Oscillator (LFO) modulation begins. Can be set from 0 (no delay, modulation begins instantly) and 99 (longest delay)

_
@Banana71 Banana71 changed the title LFO Delay and LFO Key Sync no funktion LFO Delay and LFO Key Sync no function Aug 5, 2023
@Banana71
Copy link
Author

Banana71 commented Aug 7, 2023

To clarify, I created a test sound. The first lower note is from Dexed and there is a noticeable delay before the LFO kicks in. The higher tone comes from the miniDexed and there is no noticeable delay. The tones repeat once.
The first note (Dexed) plays as expected and the second note (miniDexed) is missing the delay.

LFO-Test.mp4

@probonopd
Copy link
Owner

It'd be interesting to know how MicroDexed behaves in this regard, maybe @dcoredump can give it a try?

@dcoredump
Copy link
Contributor

Thanks for reporting! I will check this as soon as I can find some free time and come back.

@dcoredump
Copy link
Contributor

Ok, I replaced my code in Synth_Dexed with the original code for LFO handling. Maybe I have understand something wrong before. Can you check c9f52741a802ad9bb01263823650f7cc3b0b5108?

probonopd added a commit that referenced this issue Aug 8, 2023
@probonopd
Fix for #526 (hopefully?)
55396c7
@probonopd probonopd mentioned this issue Aug 8, 2023
Closed
@Banana71
Copy link
Author

Banana71 commented Aug 8, 2023

Is the bug found in #403 also fixed then?

probonopd added a commit to donluca/MiniDexed that referenced this issue Aug 8, 2023
@probonopd
Update Synth_Dexed to c9f5274
780dce1 
probonopd#526 (comment)
@probonopd
Copy link
Owner

probonopd commented Aug 8, 2023 •
edited

@Banana71 please try this build:
MiniDexed_2023-08-08-e4ad4cd

It's from #445 with Synth_Dexed updated to c9f52741a802ad9bb01263823650f7cc3b0b5108

@Banana71
Copy link
Author

Banana71 commented Aug 9, 2023

Great joy, the LFO now works as expected and the sustain pedal also holds double played notes. I am now checking all performances and will adjust the LFO if necessary. Thanks to both of you @probonopd & @dcoredump

probonopd added a commit that referenced this issue Aug 10, 2023
@donluca @probonopd
Added configuration needed to choose between Modern, OPL and Mark I e…
8a34880 
…ngines (#443)

* Added Engines Mark I and OPL

* Added Engine selection

* Update config.cpp

* Added selection for Engine Type

* Added Engine Type selection

* Update build.yml

* Fixes

* Reverting to an old commit (I screwed up)

* Small fix

* Small Fixes

* Fix for error when compiling on 64-bit platforms

* Casting of the engine variable corrected

* Changed the way we parse and set the engine type from the config file following @diyelectromusic suggestions

* Fixed a typo

* Update Synth_Dexed commit

* Moved blocks of code around

* Update Synth_Dexed to 8c67f73

#403 (comment)

* Update Synth_Dexed to a908f78

#358 (reply in thread)

* Synth_Dexed deb0905

* Add EngineMsfa.o to Makefile

* Don't add EngineMsfa.o here...

* ...but add EngineMsfa.o here

* Fix missing \

* Update build.yml

* Add Synth_Dexed to the submodules update

* Update Synth_Dexed

* Update Synth_Dexed to c9f5274

#526 (comment)

---------

Co-authored-by: probonopd <probonopd@users.noreply.github.com>
@probonopd
Copy link
Owner

Merged to main. Thanks @Banana71 and @dcoredump.

@Banana71
Copy link
Author

did you include the new performances as well?

@probonopd
Copy link
Owner

1 minute ago. Thanks @Banana71 👍

edwardgeorge pushed a commit to edwardgeorge/audio-resources that referenced this issue Nov 10, 2023
Fix for probonopd/MiniDexed#526 (hopefully?)
c9f5274
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@probonopd @dcoredump @Banana71