Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compressor, Reverb on/off #66

Closed
probonopd opened this issue Apr 3, 2022 · 6 comments
Closed

Compressor, Reverb on/off #66

probonopd opened this issue Apr 3, 2022 · 6 comments

Comments

@probonopd
Copy link
Owner

probonopd commented Apr 3, 2022 •
edited

Should we have menu entries to switch effects like Compressor, Reverb on/off?

Suggested menu structure:

  • TG1
  • ...
  • TG8
  • Effects
    • Compressor
      • On | Off
    • Reverb
      • On | Off
      • Edit Reverb
        • Size
        • High damp
        • Low damp
        • Low pass
        • Diffusion
        • Send
@rsta2
Copy link
Contributor

rsta2 commented Apr 3, 2022

OK, good suggestion. On my TODO list.

@probonopd
Copy link
Owner Author

probonopd commented Apr 3, 2022 •
edited

Let's also set the default value for Diffusion to 65. The source code comment says:

Diffusion (lower settings will make the reverb tail more "echoey", optimal value 0.65)

When setting the value to 65 in the GUI, then the echo is removed from the reverb, which I prefer a lot. To reproduce, play the default voice in staccato.

@rsta2
Copy link
Contributor

rsta2 commented Apr 3, 2022

OK. But the default Diffusion is already 20:

https://github.com/probonopd/MiniDexed/blob/main/src/minidexed.cpp#L122

@probonopd
Copy link
Owner Author

Sorry I mistyped. I meant: Set the default to 65 rather than 20.

@rsta2
Copy link
Contributor

rsta2 commented Apr 3, 2022

OK.

probonopd added a commit that referenced this issue Apr 4, 2022
@probonopd
Set diffusion default to 65
fcafaea 
Comment in the source code says: "Diffusion (lower settings will make the reverb tail more "echoey", optimal value 0.65)"
#66 (comment)
@rsta2
Copy link
Contributor

rsta2 commented Apr 4, 2022

Implemented by #69.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@probonopd @rsta2