Switchable performance files and saving all voice data parameters. #228

arsamus · 2022-05-16T04:12:33Z

This feature allows to save on Performance.ini all voice parameters edited via UI or SysEx.

probonopd · 2022-05-16T23:01:58Z

Thanks @arsamus. What is supposed to happen if VoiceDataN is not there, e.g., in the default performance.ini? Strangely, that sounds different now than without this patch.

arsamus · 2022-05-17T03:38:07Z

Thanks @arsamus. What is supposed to happen if VoiceDataN is not there, e.g., in the default performance.ini? Strangely, that sounds different now than without this patch.

For this example, nothing, just random data is apply to parameters, then if you want to load a former performance.ini file you have to go to voice menu and move the encoder 1 step up and 1 step down then save Performance to fill VoiceDataN. On a final release it is possible to define that don't set anything if the value is not properly formated or missing.

Sounds different maybe because for the example I paste the same voice parameter for all TG. But nothing would have change in relation to sound.

arsamus · 2022-05-20T18:49:46Z

Hi @probonopd I have an improvement for this feature. If VoiceDataN is not there it will priorice BankNumber and VoiceNumber values, so no random data will be load. I will commit this soon.

Moreover, I also have a solution for #125 switchable performance files (load, save and create), I can commit all in this PR. Maybe after #238 will be merged in order to get that improvement.

probonopd · 2022-05-21T05:29:34Z

Looking forward to it @arsamus.

arsamus · 2022-05-22T05:16:58Z

Looking forward to it @arsamus.

Hi @probonopd I've just PR the code for manage switcheable performances and save all voice data parameters on performance, with this patch it's possible to edit all paramenters and saved on the actual performance file or in a new one. On the other hand the new Performance menu allows to switch from diferent saved performance files, very usefull on live performance. To load selected performance it is necessary to double click on it, performance is loaded when [Ld] flag apears on left side of the LCD.

The enhacement is retrocompatible so, the only thing that it have to be done is create a folder named "performance" on root directory. performance.ini is the default performance file and has to be located on root directory, other performances files must be saved in a "performance" named folder. The format file name must be: XXXXXX_NAME.ini, XXXXXX is the incremental index and Name can't exced 14 characters. Example: 000001_Perf1.ini.

If VoiceData# parameter is not set on the file, voice and bank parameters are loaded.

Future improvements:
-Edit name of new performance via UI (now is automatically generated and can only be edited via some file manager application on a computer)
-Edit voice name via UI
-read / save performance from / to USB Pendrive.

probonopd · 2022-05-22T06:03:56Z

Thank you very much @arsamus.
Let's test MiniDexed_2022-05-22-acfb6d4.

miotislucifugis · 2022-05-22T08:18:44Z

This is super! Trying it now.

probonopd · 2022-05-22T09:27:07Z

Works for me. 👍 This is really, really useful.

Couple of questions:

Wouldn't it be more logical to have one menu entry "Performance" with submenus "Save" and "Load"?
When loading performances, can we make it so that performances are already loaded when the name is displayed, without having to double-click it? Like it works with Voices?
If the performance/ directory does not exist yet, can we create it? Currently it says "Complete" but it doesn't seem to save anything when that directory doesn't exist
Are the menu entries ordered by number? I have

performance/000002_4xE.Piano+More.ini
performance/000001_4xE.Piano.ini

Would have expected the order in the menu to be: Default, 4xE.Piano, 4xE.Piano+More but it is Default, 4xE.Piano+More, 4xE.Piano.

When one tries to save but there is no SD card in the device, it still says "Complete". Can we make it say "Card error" instead?

arsamus · 2022-05-22T14:44:52Z

Wouldn't it be more logical to have one menu entry "Performance" with submenus "Save" and "Load"?

It could be but from my point of view I think load performance needs to be very easy to get. So first level it could be the best option.

When loading performances, can we make it so that performances are already loaded when the name is displayed, without having to double-click it? Like it works with Voices?

I've asked myself this question at the begining, but there are two things here. In live performance if you want to switch from one perf.. to another you would have to pass for all perf.. in between, with de current implementation you activate the new performance just when double click it. The way that Voices works ok for voices and banks because musicians used it in an "experimental mode" when want to find a proper sound, but in performance, they would need to switch between different configs. The other thing here is that, in order to get a easy viable solution and to avoid to do agressive code interventions, performance is loaded from file at the moment you select it and it is not preloaded like voices and banks. Change this implies re-think Performanceconfig class and it dependents, creating arrays for all variables, etc.

If the performance/ directory does not exist yet, can we create it? Currently it says "Complete" but it doesn't seem to save anything when that directory doesn't exist

Yes, I've saw that, I think this is easy to fix.

Are the menu entries ordered by number? I have
performance/000002_4xE.Piano+More.ini
performance/000001_4xE.Piano.ini
``
Would have expected the order in the menu to be: Default, `4xE.Piano`, `4xE.Piano+More` but it is `Default`, `4xE.Piano+More`, `4xE.Piano`.

This would have been easy to implement, let me see how to do it.

When one tries to save but there is no SD card in the device, it still says "Complete". Can we make it say "Card error" instead?

Yes, same as 3rd question, this is related to the "saving performance fix" #238 where the function always returns a true value, but I thing it could be avoided in some way.

miotislucifugis · 2022-05-23T15:17:35Z

This seems to be working well. no problems here

arsamus · 2022-05-23T16:47:39Z

I've just update some minimum changes in order to fix or improve the following things:

if "performance" directory does not exist, attemp to create it. If it can't do it, saving new performance show "error" message.
Performance files are listed on menu ordered them by ID number (first six numbers) and not by creation date.

Respect to the performance menu. Do you think that Load and Save would have to be grouped in a new menú, or both would have to be on first level menu as it is now? I've commented my opinion above.

probonopd · 2022-05-23T16:59:07Z

Thanks @arsamus. Let's test MiniDexed_2022-05-23-55242cd

probonopd · 2022-05-24T17:19:45Z

I am terribly sorry @arsamus but it seems my latest merge has introduced merge conflicts. Before I butcher it, may I ask you to have a look at these? Thanks and sorry for the extra hassle.

arsamus · 2022-05-25T03:33:07Z

I am terribly sorry @arsamus but it seems my latest merge has introduced merge conflicts. Before I butcher it, may I ask you to have a look at these? Thanks and sorry for the extra hassle.

No problem @probonopd, done it! actually there was no real conflict

probonopd · 2022-05-25T05:15:15Z

Let's test: MiniDexed_2022-05-25-838edab

anycolorsmith · 2022-05-26T09:45:45Z

Wow! It works!

JoaquinSainz · 2022-05-27T23:22:06Z

I just tried this version it works very well, excellent implementation 👍

arsamus · 2022-05-28T03:22:50Z

It works as expected!

probonopd · 2022-05-28T06:08:31Z

Thank you very much @arsamus 👍

probonopd · 2022-11-25T07:35:11Z

src/performanceconfig.h

+	unsigned nLastFileIndex;
+	unsigned nActualPerformance = 0;  
+	unsigned nMenuSelectedPerformance = 0;
+	std::string m_nPerformanceFileName[40];


Does this limit the number of performances to 40? #379

arsamus added 5 commits May 16, 2022 00:44

Update performance.ini

eaa1a32

Update performanceconfig.cpp

aa6b15e

Update performanceconfig.h

1f61adc

Update minidexed.cpp

a714264

Update minidexed.h

6d99523

arsamus added 9 commits May 22, 2022 01:04

Merge branch 'probonopd:main' into saving-voice-data-on-performance.ini

751e218

Update performanceconfig.cpp

8692ebe

Update performanceconfig.h

6b9ff6f

Update minidexed.cpp

330312a

Update minidexed.h

141fafa

Update uimenu.cpp

bdc0033

Update uimenu.h

f0d96bd

Update minidexed.h

24d206f

Update minidexed.h

54f394a

arsamus changed the title ~~Saving voice data parameters on Performance.ini~~ Switcheable performance files and saving all voice data parameters. May 22, 2022

Update performance.ini

d4fdf36

arsamus added 3 commits May 23, 2022 13:36

Update minidexed.cpp

3ec5a66

Update performanceconfig.h

50ee7db

Update performanceconfig.cpp

5680fd0

arsamus added 5 commits May 24, 2022 23:52

Update minidexed.h

6ec1554

Update minidexed.cpp

64172e5

Update minidexed.cpp

550fab1

Merge branch 'main' into saving-voice-data-on-performance.ini

f8dbd69

Update minidexed.h

b31c56f

probonopd changed the title ~~Switcheable performance files and saving all voice data parameters.~~ Switchable performance files and saving all voice data parameters. May 26, 2022

probonopd merged commit 60ab4a5 into probonopd:main May 28, 2022

probonopd reviewed Nov 25, 2022

View reviewed changes

probonopd mentioned this pull request Mar 4, 2023

Add settings to set velocity scale #446

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switchable performance files and saving all voice data parameters. #228

Switchable performance files and saving all voice data parameters. #228

arsamus commented May 16, 2022

probonopd commented May 16, 2022

arsamus commented May 17, 2022

arsamus commented May 20, 2022

probonopd commented May 21, 2022

arsamus commented May 22, 2022

probonopd commented May 22, 2022

miotislucifugis commented May 22, 2022

probonopd commented May 22, 2022 •

edited

arsamus commented May 22, 2022

miotislucifugis commented May 23, 2022

arsamus commented May 23, 2022 •

edited

probonopd commented May 23, 2022

probonopd commented May 24, 2022 •

edited

arsamus commented May 25, 2022 •

edited

probonopd commented May 25, 2022

anycolorsmith commented May 26, 2022

JoaquinSainz commented May 27, 2022 •

edited

arsamus commented May 28, 2022

probonopd commented May 28, 2022 •

edited

probonopd Nov 25, 2022

Switchable performance files and saving all voice data parameters. #228

Switchable performance files and saving all voice data parameters. #228

Conversation

arsamus commented May 16, 2022

probonopd commented May 16, 2022

arsamus commented May 17, 2022

arsamus commented May 20, 2022

probonopd commented May 21, 2022

arsamus commented May 22, 2022

probonopd commented May 22, 2022

miotislucifugis commented May 22, 2022

probonopd commented May 22, 2022 • edited

arsamus commented May 22, 2022

miotislucifugis commented May 23, 2022

arsamus commented May 23, 2022 • edited

probonopd commented May 23, 2022

probonopd commented May 24, 2022 • edited

arsamus commented May 25, 2022 • edited

probonopd commented May 25, 2022

anycolorsmith commented May 26, 2022

JoaquinSainz commented May 27, 2022 • edited

arsamus commented May 28, 2022

probonopd commented May 28, 2022 • edited

probonopd Nov 25, 2022

Choose a reason for hiding this comment

probonopd commented May 22, 2022 •

edited

arsamus commented May 23, 2022 •

edited

probonopd commented May 24, 2022 •

edited

arsamus commented May 25, 2022 •

edited

JoaquinSainz commented May 27, 2022 •

edited

probonopd commented May 28, 2022 •

edited