Support for subdirectories in the SysEx voices directory #473
Conversation
…rrect versions of sub libraries.
… which seems to speed up loading significantly.
|
I've just realised this also includes the additional build script for #424 - sorry, that was a mistake! But as it is just one stand alone file, if you're happy with it, we can just leave it here. Kevin |
…d show as 1-indexed in the UI. But internally and via MIDI are still 0-indexed as per MIDI spec.
|
@diyelectromusic You're pushing more changes into this PR, I see the fix for bank numbers as well, maybe it would be best to keep those change on separate PRs. |
|
It is all part of sorting out the bank handling... but I don't mind either way. Separate PRs seems to cause other issues apparently (#464 (comment)) - I don't seem to understand git whatever I do ;) Up to @probonopd I guess. Kevin |
|
@diyelectromusic what does this mean for loading banks via MIDI CC messages? Edit: Probably works as usual, since the subdirectories are not visible and hence do not have to be navigated from the GUI. Great job! |
|
Yes, this shouldn't affect MIDI as we only support single voice loads over SysEx anyway and they go straight into Dexed without touching MiniDexed itself really. More on how it links together here: #454 (reply in thread) I should probably document this somewhere useful... :) Kevin |
Initial support for (nested) subdirectories in the sysex/voices folder. Splitting up directories into less than 100 files per directory seems to really help with the performance issues discussed in #456.
Kevin