feature/fhs branch produces crippled linuxdeployqt

[probonopd]

The feature/fhs branch produces crippled linuxdeployqt. It just segfaults. Is patchelf causing this?

[probonopd]

Reported upstream at NixOS/patchelf#110

[probonopd]

There is demand for this in #65

[ubruhin]

I have just tried this branch out, and it worked perfectly with my FHS-like AppDir! But I used the patchelf version from the official Ubuntu repository, I have not compiled it by myself.

As I can see, you bundle linuxdeployqt with a self-compiled version of patchelf, using their master branch. In my opinion this is not very smart, because the master branch is not considered as stable in many projects (I don't know if this also applies to patchelf). I would use the latest stable release instead (just checkout a specific tag after cloning the patchelf's repository).

Maybe this would already solve the problem with the segfault... I would love to see the feature/fhs branch merged into master as soon as possible 😃

[probonopd]

Oh wow, that is very interesting indeed! Will try to use Ubuntu's patchelf. Which exact patched version for which Ubuntu version did you use?

[ubruhin]

I have used this version: http://packages.ubuntu.com/xenial/patchelf

Now I'm trying to reproduce the results on Travis-CI, but unfortunately on their Ubuntu Trusty this package is not available...

[probonopd]

Check this one, https://github.com/probonopd/linuxdeployqt/releases/download/fhs/linuxdeployqt-continuousfhs-x86_64.AppImage - it uses patchelf_0.8.orig.tar.gz from Ubuntu (although compiled by me on Travis CI).

[ubruhin]

Check this one

Doesn't work (segmentation fault) :(

Btw. I had problems with stripped binaries, so I always passed -no-strip to linuxdeployqt. Maybe this is the cause for the segfault?

[probonopd]

My main question here is, why does this happen only with the feature/fhs branch?

[ubruhin]

Maybe because of this line which does not exist in the master branch:

strip linuxdeployqt.AppDir/usr/bin/* || continue

[probonopd]

FHS-like mode is now implemented and (hopefully) working, please try https://github.com/probonopd/linuxdeployqt/releases/tag/continuous. Turns out that strip has a bug that cripples binaries on which patchelf was previously run (NixOS/patchelf#10). Therefore, I am now checking whether a binary has a rpath starting with $ (indicating that we already ran patchelf on it), and not run strip in that case. c643d6a

Let me know if this solves it for you.

[ubruhin]

Seems to be fixed, so I think this issue can be closed...

[probonopd]

With NixOS/patchelf#117 merged, patchelf will hopefully allow binaries to be stripped after running patchelf.