Fix linuxdeployqt segfaults #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's not forget to change |
|
Good idea. Although that'll render the coredumps unusable again. But we can add a comment or something like that. |
By using a stable patchelf binary instead of compiling the latest master from NixOS/patchelf, the crash could be solved. An issue has been created in NixOS/patchelf attempting to fix this upstream. We should think about relying on stable versions (e.g. their tags) in the future instead of building the master branch, especially since linuxdeployqt is a development tool that many developers rely on.
TheAssassin
force-pushed
the
fix-segfaults-on-travis
branch
from
3c1fa4c
to
1088dfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix the segfaults on Travis (see #108).
It is split in two phases: First, I add the commit uploading debug infos to transfer.sh, to see if that works and will work for future crashes. If it works, I'll push the commit fixing the actual segfault.