Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RPATH adjustment to after library bundling #216

Merged
merged 1 commit into from Jan 19, 2018
Merged

Move RPATH adjustment to after library bundling #216

merged 1 commit into from Jan 19, 2018

Conversation

gtalent
Copy link
Contributor

@gtalent gtalent commented Jan 18, 2018

Libraries found with the RPATH could not be found by the bundler because
the RPATH was getting changed before the bundling.

Libraries found with the RPATH could not be found by the bundler because
the RPATH was getting changed before the bundling.
@probonopd
Copy link
Owner

Thank you very much. Do you have an example that did not work without this patch but works now?

@gtalent
Copy link
Contributor Author

gtalent commented Jan 19, 2018

I can't share the project that this was for, but I did reproduce it here:
https://github.com/gtalent/example

@probonopd probonopd merged commit cb3e3e6 into probonopd:master Jan 19, 2018
@probonopd
Copy link
Owner

Thank you very much.

@M-Mueller
Copy link
Contributor

This is still an issue if a library as an RPATH. For example if you have the following structure:

bin/foo
lib/libfoo.so
lib/libfoo/libbar.so

libfoo.so has an RPATH of $ORIGIN/libfoo and links against libbar.so.

linuxdeployqt will first set the RPATH of libfoo.so to $ORIGIN and then complain that ldd cannot find libbar.so. I think the order in this case should be changed as well.

@probonopd
Copy link
Owner

probonopd commented Oct 19, 2018

@M-Mueller I had attempted to fix this by adding lib/libfoo.so to LD_LIBRARY_PATH in 9a93e03 but apparently it is not working. Any help appreciated. Opening an issue for this so that it does not gets overlooked: #327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants