Correctly handle libraries in subdirectories #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @M-Mueller for looking into this. Can we do without adding Can you think of situation where this does not do "the right thing"? I am always looking to minimize the number of options because |
|
There could be a problem if LD_LIBRARY_PATH points to a folder inside the package. I'm not sure if this is a use-case though, since libraries would end up twice in the final AppImage and increasing the size unnecessarily. I that case the libraries should just be moved to the lib folder before calling linuxdeployqt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #327.
I also created a small demo project