Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make running the tests like in travis-ci easier #92

Merged
merged 5 commits into from Mar 17, 2017

Conversation

afiestas
Copy link
Contributor

The pull requests before this one had some issues in travis-ci that I couldn't reproduce locally and it took me more time to reproduce the issue than fixing it.

To reproduce the issue I created a Docker container reproducing the same environment that .travis-ci.yml creates in the CI and I thought that would be nice to contribute this upstream.

This way we can share this logic between travis CI and other systems
like for example a docker container.
As with the logic to execute the tests, this way we can share this logic
with other systems to tests linuxdeployqt.
No reason to keep it separate from the rest as far as I know
Otherwise we get into a racy situation.
This container tries to emulate the environment we have in travis-ci,
this way we can test whatever is failing on the CI locally.
@probonopd probonopd merged commit 4c33c5e into probonopd:master Mar 17, 2017
@probonopd
Copy link
Owner

probonopd commented Jan 7, 2018

Hi @afiestas ever since this was merged, working with what used to be a straightforward .travis.yml file has become more cumbersome, because one now has to edit 3 files and keep them in sync.

Would you be heavily opposed to folding tests/tests-environment.sh and tests/tests-ci.sh back into .travis.yml?

@afiestas
Copy link
Contributor Author

afiestas commented Jan 7, 2018

I still think that is nice to be able to reproduce travis-ci environment locally so we can easily fix bugs. Perhaps we can find another solution that makes this simple to maintain yet allows us to reproduce travis-ci state locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants