Testing: allow to stub logging

[gr2m]

When testing as document at https://probot.github.io/docs/testing/, there is currently no way to test what has been logged in my app. Logging can a relevant outcome of webhook handler life cycle, so we should make it easy to test for it.

We could introduce a new Probot({ logger }) option which would need to be a bunyan instance.

It's possible to work around that by directly mutating the probot instance:

  const simple = require("simple-mock")

  this.probot = new Probot({
    id: 1,
    githubToken: "test"
  });

  // mock this.probot.logger.* methods
  this.probot.logger.info = simple.mock();
  this.probot.logger.child = simple.mock().returnWith(this.probot.logger);

  this.probot.load(app);

But that's not very elegant, and I wouldn't consider that a public API.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[gr2m]

The Probot constructor now supports a log parameter. I'll add a pull request to document how to test log output

[github-actions]

🎉 This issue has been resolved in version 11.0.0-beta.1 🎉

The release is available on:

• GitHub release
• npm package (@beta dist-tag)

Your semantic-release bot 📦🚀

[github-actions]

🎉 This issue has been resolved in version 10.19.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀