feat: add constructor option for redis config

[chrishiestand]

close #845

[welcome]

Thanks for opening this pull request! A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved.

[chrishiestand]

I've tested this with redis+sentinels and it works.

127.0.0.1:6379> keys *
 1) "b_octokit-write-556121_client_running"
 3) "b_octokit-global-556121_settings"
 4) "b_octokit-notifications-556121_client_num_queued"
 5) "b_octokit-notifications-556121_client_last_seen"
 6) "b_octokit-global-556121_client_last_seen"
 7) "b_octokit-write-556121_client_last_registered"
 8) "b_octokit-global-556121_client_running"
 9) "b_octokit-notifications-556121_client_running"
10) "b_octokit-write-556121_settings"
12) "b_octokit-write-556121_client_last_seen"
13) "b_octokit-notifications-556121_settings"
14) "b_octokit-global-556121_client_last_registered"
15) "b_octokit-global-556121_client_num_queued"
16) "b_octokit-notifications-556121_client_last_registered"
17) "b_octokit-write-556121_client_num_queued"

[SGrondin]

Very cool! 😎

[tcbyrd]

Good stuff and thanks @chrishiestand! Just one request to update the type for redisConfig, if possible.

[welcome]

Thanks for your contribution to probot! 🎉

[probotbot]

🎉 This PR is included in version 8.0.0-beta.6 🎉

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[chrishiestand]

@tcbyrd It might just be something I don't see on my side, but I'm experiencing an issue with the build artifact from this PR. If I build my app using the new git branch from this PR, and run it, data is written to redis+sentinels as I expect. But if I build with npm package probot@8.0.0-beta.6, and run it, no data is written to redis+sentinels (and no errors are emitted). I suspect there is a difference between the shipped npm package and building from the git repo. I could move this problem into an issue so it can be more readily seen by anyone else experiencing it.

Here is the except from my app Dockerfile that shows how I'm building directly from the git branch:

FROM node:10-alpine

# temporary extras RUNs for probot testing
RUN echo installing os dependencies... && \
    apk add --update --no-cache -t build-deps git make python
RUN echo installing node dependencies... && \
    npm --prefix=/app install
RUN echo probot build... && \
    cd /app/node_modules/ && \
    rm -rf probot && \ 
    git clone --single-branch --branch v8.0.0-beta.6@beta https://github.com/probot/probot && \
    cd probot && \
    npm install && \
    npm run build && \
    echo cleaning up... && \
    apk del build-deps && \
    rm -rf /root/.npm /root/.node-gyp

[chrishiestand]

Sorry, those were typos in the comment (not in my dockerfile). I fixed them via edit. I am using the git tag v8.0.0-beta.6@beta

[chrishiestand]

In both cases, package.json shows

    "probot": "^8.0.0-beta.6",

[tcbyrd]

Just to be sure, does it work if you install from NPM, and just not from the tagged release? I'm not 💯 clear how semantic release cuts the release. Maybe @gr2m would know?

[chrishiestand]

Install which version from npm? If you mean 8.0.0-beta.6 then yeah, the problem is that it doesn't write to redis as expected. That seems to be the correct version: https://www.npmjs.com/package/probot/v/8.0.0-beta.6?activeTab=versions

In the case of installing from npm my Dockerfile excerpt is this:

# temporary extras RUNs for probot testing
RUN echo installing os dependencies... && \
    apk add --update --no-cache -t build-deps git make python
RUN echo installing node dependencies... && \
    npm --prefix=/app install && \
    echo cleaning up... && \
    apk del build-deps && \
    rm -rf /root/.npm /root/.node-gyp