New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Initial webhook-event-check feature #1078
Conversation
Any subsequent hook-check requests will be silently ignored.
Adding return values to the main function is a comprimise to allow for easier testing
Naming is hard :) I like |
Let us know when this PR is ready for review. If you are still working on it, can you prefix the pull request with |
OK, I think it's ready for your review. |
🎉 This PR is included in version 9.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
was broken in probot/probot#1078
@MaximDevoir fyi, I'll have to remove the feature for now as it become a blocker for our serverless/function milestone. But I created a follow up issue to find another solution: #1435 |
A hook-check feature will warn developers if they are attempting to listen to an event their GitHub App is not subscribed to.
========
100% unit tested when running
yarn run jest --coverage check-event.test.ts
.========
Example warning of an invalid event name (e.g. typo):
Example warning if an application is not connected to the Internet or bad configuration settings:
Limitations
app.on('issues.opened, ...)
. Event-check will warn the user if the GitHub App is not subscribed to theissues
event - but will not verify if the action (opened
) is valid.Closes #1042