feat: un-deprecate (app) => {}. Deprecate ({ app, getRouter }) => {} in favor of (app, { getRouter }) => {}
#1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…{}` in favor of `(app, { getRouter }) => {}`
gr2m
force-pushed
the
1438/revert-app-function-change
branch
from
3e0d9f8
to
c6bc339
Compare
|
🎉 This PR is included in version 10.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see discussion at https://github.com/probot/probot/issues/1286\#issuecomment-744094299
Once this is merged, the
betarelease needs to be adjusted accordingly. It will be a breaking change between beta.3 and beta.4, I will not introduce a deprecation during betaView rendered .github/ISSUE_TEMPLATE/Bug_report.md
View rendered README.md
View rendered README.pt-br.md
View rendered docs/extensions.md
View rendered docs/github-api.md
View rendered docs/hello-world.md
View rendered docs/http.md
View rendered docs/logging.md
View rendered docs/pagination.md
View rendered docs/persistence.md
View rendered docs/serverless-deployment.md
View rendered docs/webhooks.md