Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): pin version of @octokit/webhooks #1472

Merged
merged 1 commit into from
Feb 4, 2021

Conversation

wolfy1339
Copy link
Collaborator

The new types introduced in @octokit/webhooks@7.22.0, are incompatible with the current codebase. This will prevent users from getting anything newer than the pinned version in order to avoid type errors for end-users

The new types introduced in `@octokit/webhooks@7.22.0`, are incompatible with the current codebase. This will prevent users from getting anything newer than the pinned version in order to avoid type errors for end-users
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you on this one, we can figure this out later.

@gr2m gr2m merged commit cd14dd4 into probot:master Feb 4, 2021
@github-actions
Copy link

github-actions bot commented Feb 4, 2021

🎉 This PR is included in version 11.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

gr2m pushed a commit that referenced this pull request Feb 12, 2021
The new types introduced in `@octokit/webhooks@7.22.0`, are incompatible with the current codebase. This will prevent users from getting anything newer than the pinned version in order to avoid type errors for end-users
@gr2m
Copy link
Contributor

gr2m commented Feb 28, 2021

@wolfy1339 do you know what the follow up issue here is? What do we need to do to unpin the dependency on @octokit/webhooks?

@wolfy1339 wolfy1339 deleted the pin-octokit-webhooks branch February 28, 2021 20:24
@wolfy1339
Copy link
Collaborator Author

The way the payload types are accessed are different. It would require breaking changes to the TS types.
We'd have to wrap around the Webhooks class, due to the removal of the * and 'error' events to avoid breaking changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants