Add await to probot and server load #1517
Conversation
|
Thanks for opening this pull request! A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved. |
src/probot.ts
Outdated
| @@ -121,6 +121,6 @@ export class Probot { | |||
| return; | |||
| } | |||
|
|
|||
| return appFn(this, {}); | |||
| return await appFn(this, {}); | |||
There was a problem hiding this comment.
the load function is already async, this change makes no difference. If appFn is async it will return a promise, and await server.load will await that promise, no need to add an await here
There was a problem hiding this comment.
Do you mean because a async function will only wraps a return value in a promise if it is not a promise itself?
As described here?: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/async_function#rewriting_a_promise_chain_with_an_async_function
I removed the await here.
|
The end-to-end tests pass when you run |
|
Thanks for your contribution to probot! 🎉 |
|
🎉 This PR is included in version 11.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thanks for the fast fix! |
Some part already have an await some not. This should make it behave the same if the app has an async entry point.
Please let me know what you think.
One test fails for me (end-to-end-tests › hello-world app) but it does that even without my change.