feat: Support ESM apps #1685
Closed
feat: Support ESM apps #1685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests work locally, I dont know why they fail on actions |
|
The fail is related to nodejs/node#35889. --experimental-vm-modules is only required in Jest, not when actually using the app. I'm not sure what's the best way to proceed here. Trying to run the different code in the tests defeats the point of the tests |
|
Thanks for looking at this. I'm no expert on this CJS/ESM stuff, but is it possible to change the |
|
Yes, that is possible, but would require more major refactoring changes to be native ESM. I can try to do that, but it could break some apps using probot, it'd require a lot of testing. |
wolfy1339
force-pushed
the
aarondewes/support-esm-apps-1684
branch
from
b906ded
to
db47312
Compare
|
Part of #1821. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1684.
This would require Node 14, which is a breaking change, but Node 14 is the oldest still supported LTS version, so I think it's not a problem