Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): add dependency review and license check for production dependencies #1897

Merged
merged 6 commits into from
Nov 14, 2023

Conversation

Uzlopak
Copy link
Collaborator

@Uzlopak Uzlopak commented Nov 13, 2023

This is what we do in fastify

We use the license-checker and not the option of dependency review action, because the license-checker was more reliable in the past.

We have to be careful, as e.g. @isaacs is moving to the BlueOak license for his packages and isaacs controles alot of dependencies e.g. glob. Blue Oak is not OSI approved and could result in license issues for projects dependending on probot, if we are not careful to detect them in the production dependencies. So if e.g. isaacs decides that he wants to move from MIT to BlueOak for glob, we need to detect that.

@Uzlopak Uzlopak requested a review from a team as a code owner November 13, 2023 10:27
@Uzlopak
Copy link
Collaborator Author

Uzlopak commented Nov 13, 2023

OK! glob is already having a dep containing blue oak.

@AaronDewes
Copy link
Member

OK! glob is already having a dep containing blue oak.

There's globby which may be good as a replacement...

@AaronDewes
Copy link
Member

A PR to replace one usage of glob is here: probot/octokit-plugin-config#244. This seems to be the only thing that currently requires glob as a dependency if we exclude devDependencies of probot, and it a mistake there.

@Uzlopak
Copy link
Collaborator Author

Uzlopak commented Nov 13, 2023

You beat me to it. Wanted to also propose a PR for that ;).

@Uzlopak
Copy link
Collaborator Author

Uzlopak commented Nov 14, 2023

@AaronDewes
now it works as expected ;)

.github/workflows/test.yml Outdated Show resolved Hide resolved
@AaronDewes
Copy link
Member

image

@gr2m I can't merge for some reason, can you have a look what this "test" is?

@Uzlopak
Copy link
Collaborator Author

Uzlopak commented Nov 14, 2023

I guess there is a setting which makes it mandatory to have a job "test" in the repo settings. renamed test_codecov back to test

@AaronDewes AaronDewes enabled auto-merge (squash) November 14, 2023 07:43
@AaronDewes
Copy link
Member

Did not seem to work, but it could be a bug in GitHub.

auto-merge was automatically disabled November 14, 2023 07:45

Head branch was pushed to by a user without write access

@AaronDewes AaronDewes merged commit 9a9079d into probot:beta Nov 14, 2023
15 checks passed
@Uzlopak Uzlopak deleted the add-license-check-wf branch November 14, 2023 07:57
Copy link

🎉 This PR is included in version 13.0.0-beta.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants