ci: use redis for ci/cd #1905
Merged
ci: use redis for ci/cd #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronDewes
reviewed
Nov 14, 2023
AaronDewes
approved these changes
Nov 14, 2023
Co-authored-by: Aaron Dewes <aaron@runcitadel.space>
gr2m
reviewed
Nov 15, 2023
|
I would actually have atleast one test against redis. Just to ensure, that there are no side effects because of the use of redis. |
|
Any way we could add a test with REDIS in CI only? Like a smoke test? Without polluting package.json and our existing tests? |
|
Yes |
Uzlopak
commented
Nov 15, 2023
Co-authored-by: Aras Abbasi <aras.abbasi@googlemail.com>
|
Yay! |
|
🎉 This PR is included in version 13.0.0-beta.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lets see if this works. But if it works, we can test the redis code too ;).
Maybe just test against redis 7?