Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename plugin => app #210

Merged
merged 9 commits into from Aug 24, 2017
Merged

Rename plugin => app #210

merged 9 commits into from Aug 24, 2017

Conversation

bkeepers
Copy link
Contributor

@bkeepers bkeepers commented Aug 20, 2017

As discussed in #207 (comment), this changes the terminology:

  • plugins => apps - Akin to "react apps" or "rails apps", Probot apps are just node apps that have a dependency on probot and use features of the framework. They can be run standalone or combined with other apps with the probot run command.
  • helper => extension - Probot extensions are reusable modules that extend Probot itself.
    probot-scheduler is currently the only example, but there are a few others I can imagine, such as probot-command which would do slash command handling similar to what @jbjonesjr's snooze app does.

TODO:

* origin/master:
  The Slack chat channel on the Internet machine
  Clean up link to slack channel
  Add link to slack channel
  Adds a line break
  add test to ensure deprecation occurs
  add version for deprecation to console.warn and inline comment
  it's on the same tab
  annoying space 💢
  bot -> app
  0 -> 1 silly markdown
  Create CONTRIBUTING.md
  Add linter extend to package.json
  clarify REST API
  use settings.yml
  Update development.md
  Fix urls to example apps
  Fix link to example GitHub profile
  Bumps webhook dep and adds webhookPath config
@bkeepers bkeepers requested a review from a team August 23, 2017 01:38
@bkeepers
Copy link
Contributor Author

  • Figure out what to do with lib/plugin.js

I think lib/plugin.js needs refactored quite a bit. For now, all public-facing references to "plugin" have been replaced, so I'd like to leave further changes to a future pull request.

Copy link
Contributor

@hiimbex hiimbex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! +1 to updating plugin.js in a separate pr.

* origin/master:
  maximize cat gifage
  create new error instead of eslint disable
  confirmed my localdev is is 😵
  tetsing if a standard error fails on CI
  STANDARD LINT ALL OF THE THINGS
  update plugin usage
  Add support for update-docs and new-issue-welcome
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants