New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename plugin => app #210
Merged
Merged
Rename plugin => app #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 22, 2017
* origin/master: The Slack chat channel on the Internet machine Clean up link to slack channel Add link to slack channel Adds a line break add test to ensure deprecation occurs add version for deprecation to console.warn and inline comment it's on the same tab annoying space 💢 bot -> app 0 -> 1 silly markdown Create CONTRIBUTING.md Add linter extend to package.json clarify REST API use settings.yml Update development.md Fix urls to example apps Fix link to example GitHub profile Bumps webhook dep and adds webhookPath config
This was referenced Aug 23, 2017
I think |
hiimbex
approved these changes
Aug 24, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! +1 to updating plugin.js
in a separate pr.
* origin/master: maximize cat gifage create new error instead of eslint disable confirmed my localdev is is 😵 tetsing if a standard error fails on CI STANDARD LINT ALL OF THE THINGS update plugin usage Add support for update-docs and new-issue-welcome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #207 (comment), this changes the terminology:
probot
and use features of the framework. They can be run standalone or combined with other apps with theprobot run
command.probot-scheduler
is currently the only example, but there are a few others I can imagine, such asprobot-command
which would do slash command handling similar to what @jbjonesjr's snooze app does.TODO:
Figure out what to do withwaiting until future iterationlib/plugin.js
#probot-plugin
=>#probot-app
topic on all repos