Add DISABLE_TUNNEL variable #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonEtco
reviewed
Sep 20, 2017
| @@ -26,7 +26,7 @@ if (!program.privateKey) { | |||
| program.privateKey = findPrivateKey() | |||
| } | |||
|
|
|||
| if (program.tunnel) { | |||
| if (program.tunnel && !process.env.DISABLE_TUNNEL) { | |||
There was a problem hiding this comment.
LGTM ✨
Asking questions for the sake of it, what do you think about changing it to the following? Makes it a little more predicable. Only DISABLE_TUNNEL=true will truly disable it.
if (... && process.env.DISABLE_TUNNEL !== true)
There was a problem hiding this comment.
I think that environment variable would actually be a string.
There was a problem hiding this comment.
Yeah, as @wilhelmklopp points out, regardless to what the environment variable is set to, it will be a string, so setting it to anything should evaluate to true.
hiimbex
approved these changes
Sep 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
DISABLE_TUNNELto any value will prevent localtunnel from being set up, even if the development dependency is installed.Fixes #259
cc @wilhelmklopp