Added request logging #270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We would appreciate it if you could provide us with more info about this issue/pr! |
|
Thanks for opening this pull request! Please check out our contributing guidelines. |
|
At first glance this is looking good. I'll pull it down and test it out soon. Thanks for the PR @stofolus! |
|
Ignoring this for now since the plan is to move to jest: #288 |
|
Sorry, this was from an overzealous copy/paste on tabs that I had open. |
JasonEtco
requested changes
Oct 16, 2017
lib/server.js
Outdated
| path: req.path, | ||
| ip: req.ip, | ||
| hostname: | ||
| req.hostname, |
There was a problem hiding this comment.
This should be on one line, would you mind making that fix please?
There was a problem hiding this comment.
Sure. I will take care of this later today
This was referenced Nov 9, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation for #231