Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use logger for localtunnel messages #349

Merged
merged 1 commit into from Nov 26, 2017
Merged

Use logger for localtunnel messages #349

merged 1 commit into from Nov 26, 2017

Conversation

bkeepers
Copy link
Contributor

@bkeepers bkeepers commented Nov 25, 2017 •
edited

This updates the messages about localtunnel to use the built-in logger:

screen shot 2017-11-25 at 4 34 25 pm

cc #320

@bkeepers bkeepers requested a review from a team November 25, 2017 22:38
JasonEtco
JasonEtco approved these changes Nov 25, 2017
View reviewed changes
Copy link
Member

@JasonEtco JasonEtco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, also because it includes the localtunnel setup into createProbot().

@bkeepers bkeepers merged commit b5d05b3 into master Nov 26, 2017
@bkeepers bkeepers deleted the log-tunnel branch November 26, 2017 04:03
bkeepers added a commit that referenced this pull request Dec 6, 2017
@bkeepers
Merge remote-tracking branch 'origin/master' into octokit-webhooks
5274137 
* origin/master:
  Add example to README (#361)
  Enable Codecov (#360)
  Implement GHE Support (#331)
  refactor: Extract Sentry logging to a built-in plugin (#353)
  Log full requests as trace (#352)
  Improve GitHub logging (#351)
  General cleanup (#350)
  doc: Logging (#348)
  feat: Add request/response logging (#322)
  fix: Improve log messages for localtunnel (#349)

# Conflicts:
#	lib/index.js
#	lib/robot.js
#	test/robot.test.js
@saravntbe saravntbe mentioned this pull request Jan 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JasonEtco JasonEtco JasonEtco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bkeepers @JasonEtco