Properly handle async errors #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Express is not optimized for async/await, so async errors are currently bubbled up to the main process and not properly handled. You can read more about Express error handling here: http://thecodebarbarian.com/80-20-guide-to-express-error-handling Since Probot is so async/await heavy, I think it makes sense to pull in this extension that properly handles rejected promises in Express.
Codecov Report
@@ Coverage Diff @@
## master #384 +/- ##
==========================================
- Coverage 95.03% 94.02% -1.01%
==========================================
Files 18 19 +1
Lines 262 268 +6
Branches 30 30
==========================================
+ Hits 249 252 +3
- Misses 11 14 +3
Partials 2 2 |
|
Using this branch on the project I'm working on and it's helped expose a bunch of issues where exceptions were being thrown in async code. |
JasonEtco
approved these changes
Jan 4, 2018
tcbyrd
approved these changes
Jan 4, 2018
|
@bkeepers bump to merge this, as we currently can't use new probot features since our project's probot dependency is pinned to this branch |
* origin/master: Customize Codecov ☂️ (#386) Remove localtunnel (#387) Use smee-client instead of EventSource directly (#389) Fix lint error introduced in #390 Document probot-config extension (#390) feature: Add early termination to paginate method (#329) docs: Update "Remix on Glitch" button link (#388) docs: How to install Node and Probot for Development (#381) [Suggestion] Use marketplace link instread of original link (#383)
I would be up for that. I haven't used koa, but definitely seems like a better fit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Express is not optimized for async/await, so async errors are currently bubbled up to the main process and not properly handled. You can read more about Express error handling here:
http://thecodebarbarian.com/80-20-guide-to-express-error-handling
Since Probot is so async/await heavy, I think it makes sense to pull in this extension that properly handles rejected promises in Express.