remove manual base64 encoding/decoding of private key #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! A contributor should be by to give feedback soon. In the meantime, please check out the contributing guidelines and explore other ways you can get involved. |
|
Thanks for your contribution to probot! 🎉 |
bkeepers
added a commit
that referenced
this pull request
Oct 7, 2018
…dapter * origin/master: (51 commits) remove manual base64 encoding/decoding of private key (#717) chore(test): convert app/default test to TypeScript (#703) chore(test): convert Sentry test to TypeScript (#702) Detect color support (#708) Fix two typos (#709) 7.2.0 httpSSSSSSS (#701) chore(tests): convert serializers test to TypeScript (#695) Update development docs to explain GitHub App Manifests (#700) Probot Support for GitHub App Manifests (#650) Resolve Jest transform option deprecation warning (#694) chore(package): update nock to version 10.0.0 7.1.2 fix(package): require @octokit/webhooks@^5.0.2 (#691) Relax webhooks requirement fix(package): update @octokit/webhooks to version 5.0.1 Update best-practices.md (#682) 7.1.1 add npm ignore for package-locks update octokit/rest and tests to use /app/installations (#681) ...
bkeepers
added a commit
that referenced
this pull request
Oct 10, 2018
…ommand * origin/master: Create README.pt-br.md (#711) fix(package): update dotenv to version 6.1.0 (#724) Update octokit rest (#721) remove manual base64 encoding/decoding of private key (#717) chore(test): convert app/default test to TypeScript (#703) chore(test): convert Sentry test to TypeScript (#702) Detect color support (#708) Fix two typos (#709)
bkeepers
added a commit
to macklinu/probot
that referenced
this pull request
Oct 25, 2018
* origin/master: (29 commits) Add done parameter to paginate callback in GitHubAPI interface (probot#718) docs: Fix typo (probot#741) docs: Pretty readme (probot#740) robot => app Document deployment to GitHub Actions (probot#739) Fix: Allow starting probot without token or id/cert (probot#738) 7.3.0 Update docs for manually receiving events (probot#730) Deprecate `probot simulate` in favor of `probot receive` (probot#726) Wrap pem in quotes to make Glitch happy (probot#737) Update development.md (probot#735) chore(package): update @octokit/rest to version 15.13.1 (probot#732) Update standard-markdown to the latest version 🚀and lint docs chore(package): update typedoc to version 0.13.0 (probot#731) chore(package): update commander to version 2.19.0 (probot#729) Create README.pt-br.md (probot#711) fix(package): update dotenv to version 6.1.0 (probot#724) Update octokit rest (probot#721) remove manual base64 encoding/decoding of private key (probot#717) chore(test): convert app/default test to TypeScript (probot#703) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update deployment instructions for Now
Why
Manually base64 encoding the the
PRIVATE_KEYvalue and decoding it in anow-starthook is no longer necessary now that Probot recognizes and decodes base64 encoded private keys. This should simply the deployment process as there is one less step for new users to get a Probot deployment up and running. 😊View rendered docs/deployment.md