Fix typings for stats app #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wolfy1339 wanna pull in those changes and merge master for this? |
|
Sure thing. |
|
Done. |
According to the Octokit types, the paginate() function's callback has an argument of type `Promise<AnyResponse>`, but it was being used as if it wasn't in a Promise
|
@hiimbex Please re-review this as I added some fixes for some stuff that popped up in the Travis CI build log |
|
Just a gentle ping, so you can look at the new changes and get this merged |
tcbyrd
approved these changes
Nov 3, 2018
|
Hey there. Is there anything holding back this PR? |
|
@wolfy1339 Sorry for the delay on this. I fixed the conflicts we caused from some other PRs that landed. Merging now. Thanks for the contribution! |
|
Thanks for your contribution to probot! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the typings file would be empty, now it will contain the proper typings