This repository has been archived by the owner on May 20, 2023. It is now read-only.
Exclude Draft PRs #319
Closed
Exclude Draft PRs #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 21, 2021 09:51
theaccordance
commented
Jan 21, 2021
| /** Can't search issues with draft:false in the query so this is appended only for pulls **/ | ||
| if (type === 'pulls') { | ||
| queryParts.push(exemptDrafts ? 'draft:false' : '') | ||
| } |
There was a problem hiding this comment.
I didn't write tests for this yet, but if this PR is agreeable I will definitely add those.
As for why I conditionally wrapped it - if you include draft:boolean in your query for issues, nothing returns - so this can only be applied for pulls.
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
dantwining
reviewed
Jun 15, 2021
|
@bkeepers I realize your bio says "formerly github" but is there someone you can nudge about this pull request? I'm gonna close it otherwise and find an alternative solution. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Requests adds
exemptDraftsoption to exclude Draft pull requests.Related Issue: #265
View rendered README.md