[FEAT] Add link to index.html when clicking the PA logo #251
Conversation
|
|
|
Thanks @kylejohnston for your contribution. I will review it soon. |
tbouffard
added
hacktoberfest-accepted
✔️ Responsive layout improvements on the examples home page (00cbc9a)Better title height and section title not cropped when accessed by anchors
Single card displayed on small screens
|
There was a problem hiding this comment.
Thanks for the contribution. It looks great. I only have minor change requests.
✔️ the responsive layout improvements work great, see #251 (comment)
❌ the href to the examples home page should use relative path to work with local file browsing and statically.io
demo/load-and-navigation/index.html
Outdated
| <a class="home flex items-center" href="/examples/index.html"> | ||
| <img src="static/img/logo_64x64_white.png" alt="logo" class="logo h-11 m-2 ml-3"> | ||
| <span class="h-11 m-2 py-1 text-3xl">BPMN Visualization</span> | ||
| </a> |
There was a problem hiding this comment.
ℹ️ The content here is copied during release of https://github.com/process-analytics/bpmn-visualization-js/ so it will be erased next time we update it like in #252.
This wasn't mentioned in the issue, so feel free to revert or keep it. We will handle it later in the bpmn-visualization-js repository.
examples/custom-behavior/call-activity-with-modal-on-mouse-over/index.html
Outdated
Show resolved
Hide resolved
tbouffard
changed the title
|
Just made new commits that address the requested changes. Let me know if there's anything else! |
remove extra 'examples' part in the relative url
There was a problem hiding this comment.
@kylejohnston thanks for implementing the requested changes.
I have directly pushed some small changes to finalize the Pull Request. It was faster (and less annoying for you) to make them myself rather than commenting and asking you to make the changes 😄.
I'll leave the Pull Request open for a few days for you to check if there are any issues with my edits. Then I will merge it.
❓ I have one last question because I am curious 😸. I would like to know how you found out about our repository. Do you work in the field of BPMN, Process Analytics or Process Mining? or did you just make a contribution as part of Hacktoberfest for instance?
Anyway, thanks again for your contribution.
|
Thank you for the update and the opportunity to contribute! I do not work in this field; I searched for repos with design / frontend issues tagged with hacktoberfest. |
Open in a new tab as we have no way to go back to home from the examples hosted externally
|
✔️ latest tests done with https://cdn.statically.io/gh/process-analytics/bpmn-visualization-examples/8e667c8fc593f7ce9adbe8907aed2007bca13cf8/examples/index.html are ok, so merging. |
tbouffard
changed the title
closes #245
All examples
Homepage