Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Review the Gitpod configuration #2003

Merged
merged 4 commits into from
Jun 1, 2022

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented May 30, 2022

Remove the Theia configuration: gitpod don't use theia anymore
Update the VSCode configuration

  • fix the launcher configuration. The 'disableOptimisticBPs' property is not allowed in both VSCode and Gitpod
  • add launcher for integration tests

Improve the documentation

Notes

The need for improvements was detected while testing Gitpod for #1416

Theia support removal

I have tested that the e2e tests are passing on gitpod.

Remove the `Theia` configuration: gitpod don't use theia anymore
Update the VSCode configuration
  - fix the launcher configuration. The 'disableOptimisticBPs' property is not allowed in both VSCode and Gitpod
  - add launcher for integration tests
Improve the documentation
Copy link
Member

@csouchet csouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Gitpod. everything works fine 👍🏻

@csouchet csouchet merged commit 99adf01 into master Jun 1, 2022
@csouchet csouchet deleted the infra/review_gitpod_configuration branch June 1, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code refactoring
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants