Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Render compensation events #707

Merged
merged 7 commits into from Oct 7, 2020
Merged

[FEAT] Render compensation events #707

merged 7 commits into from Oct 7, 2020

Conversation

alachambre
Copy link

Here is the current render:
compensation_light

Here is the zoom of the current render (pixel perfect for the alignement 🍾 )
compensation_zoom

Here is an other test, with a bolder icon:
compensation_bold

closes #655

@tbouffard tbouffard added BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request external contribution 👤 Pull requests provided by someone who is not a core maintainer labels Oct 6, 2020
@tbouffard
Copy link
Member

tbouffard commented Oct 6, 2020 •
edited

Thanks @alachambre for this contribution. The icon rendering looks good to me.
About the icon stroke width used in the screenshot, it seems that the thinner is produced with a 1.5 value (as in 50a6464) and the "bolder" is produced with a 2.0 value.
Can you confirm this?

I personally prefer the thinner stroke width which looks more consistent with existing icons.
We will review this with the other maintainers.

Please remember that your Pull Request must credit the author of the icon if you don't create the icon by yourself. See the documentation

@aibcmars
Copy link
Contributor

aibcmars commented Oct 6, 2020

thinner stroke 👍

@NathalieC
Copy link
Contributor

Consistency with other icons is what I'll value. So if thiner stroke is more consistent, then thiner stroke it must be for me.

@csouchet
Copy link
Member

csouchet commented Oct 6, 2020

I prefer the first icon 😄

@tbouffard
Copy link
Member

@alachambre all maintainers are ok with the thinner icon you have proposed. Please credit the icon author and we will review this pull request quickly 😸

tbouffard
tbouffard reviewed Oct 6, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a minor changes is requested in the documentation, otherwise this is perfect 😄

docs/bpmn-support.adoc Outdated
@@ -143,6 +143,7 @@ The event definition can be defined on the event or on the definitions.
* message: https://github.com/jgraph/drawio/blob/0e19be6b42755790a749af30450c78c0d83be765/src/main/webapp/shapes/bpmn/mxBpmnShape2.js#L465[draw.io bpmn mxgraph stencil]
* signal: https://thenounproject.com/term/triangle/2452089/[triangle] By https://thenounproject.com/imamdji99[Imam], ID from https://thenounproject.com
* timer: https://www.flaticon.com/free-icon/clock_223404[Timer Icon] "Icons made by https://www.flaticon.com/authors/kirill-kazachek[Kirill Kazachek] from https://www.flaticon.com"
* compensation: https://thenounproject.com/vityavorobyev/icon/443401/[Rewind Button ] "Icons made by https://thenounproject.com/vityavorobyev/[Viktor Vorobyev] from https://thenounproject.com/"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ can you move this on top? this is to sort the elements in alphabetic order

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
And for the question about the stroke size, I don't know, I tried with the two icons you proposed: #355 (comment)

@csouchet csouchet added the hacktoberfest-accepted Accepted Pull Request during Hacktoberfest label Oct 7, 2020
@csouchet csouchet merged commit d9664fb into process-analytics:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard left review comments

@csouchet csouchet csouchet approved these changes

Assignees
No one assigned
Labels
BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request external contribution 👤 Pull requests provided by someone who is not a core maintainer hacktoberfest-accepted Accepted Pull Request during Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Render Compensation Events
5 participants
@alachambre @tbouffard @aibcmars @NathalieC @csouchet