Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Render business rule task #709

Merged
merged 3 commits into from
Oct 7, 2020
Merged

[FEAT] Render business rule task #709

merged 3 commits into from
Oct 7, 2020

Conversation

benjaminParisel
Copy link
Contributor

Render business rule task
black

closes #646

@tbouffard
Copy link
Member

@benjaminParisel Thanks for this contribution, the L&F is great
Can you confirm that you are the author of the icon please?
If not, please remember that your Pull Request must credit the author of the icon if you don't create the icon by yourself. See the documentation

@tbouffard tbouffard added BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request external contribution 👤 Pull requests provided by someone who is not a core maintainer labels Oct 6, 2020
csouchet
csouchet reviewed Oct 6, 2020
View reviewed changes
src/component/mxgraph/shape/render/IconPainter.ts
/**
* This icon is used by `business rule task`.
*/
paintBusinessRuleIcon({ setIconOrigin, c, shape, ratioFromParent, icon }: PaintParameter): void {
Copy link
Member

@csouchet csouchet Oct 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the source of the SVG icon in comment (and in the readme if it's not already here), and in bpmn-support.adoc

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This icon is made by @alachambre and me from scratch

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://twitter.com/adrlach if you want something for the credit

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here is the svg source, in case you need it in the futur: https://gofile.io/d/pi6wxt
(I can't add svg file in comment apparently...)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 😄 We don't put credit when it's done from strach.
But you need to update bpmn-support.adoc in order to inform that the render is done 😉

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So hard to be an artist nowaday 😢

@tbouffard
Copy link
Member

SVG used as source for the icon: business-rule.svg.zip (from https://gofile.io/d/pi6wxt)

tbouffard
tbouffard approved these changes Oct 7, 2020
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csouchet csouchet added the hacktoberfest-accepted Accepted Pull Request during Hacktoberfest label Oct 7, 2020
@csouchet csouchet merged commit 311fff2 into process-analytics:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alachambre alachambre alachambre left review comments

@csouchet csouchet csouchet approved these changes

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
BPMN rendering Something about the way the lib is rendering BPMN elements enhancement New feature or request external contribution 👤 Pull requests provided by someone who is not a core maintainer hacktoberfest-accepted Accepted Pull Request during Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Render Business Rule task
4 participants
@benjaminParisel @tbouffard @csouchet @alachambre