[FEAT] Render all Conditional Events #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csouchet
changed the title
csouchet
added
BPMN rendering
csouchet
requested changes
Oct 21, 2020
There was a problem hiding this comment.
Rebase needed on https://github.com/VickyPicky/bpmn-visualization-js/tree/317-Detect_Non-interrupting_Conditional_Intermediate_Event_Attached_to_an_Activity_Boundary
A little modification of the documentation is missing, and everything is ok 😄
| @@ -326,6 +326,10 @@ The event definition can be defined on the event or on the definitions. | |||
| |Signal Non-interrupting Boundary Event | |||
| |icon:check-circle-o[] | |||
| |The stroke & icon width may be adjusted | |||
|
|
|||
| |Conditional Non-interrupting Boundary Event | |||
There was a problem hiding this comment.
The documentation for the other Conditional events is missing 😢
There was a problem hiding this comment.
There was some issue with merge
I think doc is complete, @csouchet can you confirm please?
|
The final render is OK |
|
Rebase from the |
csouchet
removed
the
depends on another PR ⚠️
aibcmars
force-pushed
the
651-Render_Non-interrupting_Conditional_Intermediate_Event_Attached_to_an_Activity_Boundary
branch
from
56264fa
to
ec2f842
Compare
aibcmars
removed
the
rebase needed 💥
…termediate_Event_Attached_to_an_Activity_Boundary
csouchet
approved these changes
Oct 22, 2020
csouchet
added
the
hacktoberfest-accepted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #651