Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more built-in functions #16

Closed
50 of 51 tasks
gaocegege opened this issue Mar 9, 2017 · 20 comments
Closed
50 of 51 tasks

Support more built-in functions #16

gaocegege opened this issue Mar 9, 2017 · 20 comments

Comments

@gaocegege
Copy link
Member

gaocegege commented Mar 9, 2017

@PatrickMurphy
Copy link

Gaocegege, I am interested in contributing to this repo, If you have any direction of what issues, or what built in functions you would like to prioritize I would be happy to claim some of the work and send pull requests.

@gaocegege
Copy link
Member Author

@PatrickMurphy Thanks for your interest 🎉

Today, I'll write some documentation about the architecture of Processing.R and tag some issues to "for new contributors". If you have any problems when you read the code, feel free to @ me in GitHub or https://gitter.im/gaocegege/Processing.R.

@gaocegege
Copy link
Member Author

re @PatrickMurphy

ref #16 (comment) Processing.R will focus on 2D & 3D Primitives at the first.

Functions such as arc() and ellipse() are easy to implement. If you want to contribute, this is a good entrypoint :)

@jeremydouglass
Copy link
Member

@gaocegege -- this built-in functions list includes cursor().

Is it part of the plan support mouse input and interaction like mouseX mouseY mousePressed() mouseReleased() -- or will the first phase stay focused on non-interactive sketches? Without mouse interaction there isn't much point in a cursor() command.

@jeremydouglass
Copy link
Member

Also, should box() be crossed off the list? It looked like it was implemented for the 3d-cube.R example.

@gaocegege
Copy link
Member Author

@jeremydouglass

box in Processing has two definitions: box(size) and box(w, h, d), I only implement one for the 3D example. I treat the example as a feasibility research, so I will add all 3d functions soon.

@gaocegege
Copy link
Member Author

gaocegege commented May 12, 2017

Hi, there are too many built-in functions in Processing, so I am not sure if I have the ability to implement all functions on my own in the first evaluation. I am trying to attract some contributors to Processing.R. We could also talk about the priority between the functions and have a more detailed plan.

@jeremydouglass
Copy link
Member

jeremydouglass commented May 12, 2017

@gaocegege --

You definitely should not try to implement all the built-ins on your own! Your plan to call for contributors is a good one.

I would suggest either removing cursor() from the list entirely or else putting it in its own section alongside with the other mouse related functions. Mouse interaction would probably be an advanced issue for a contributor, so if you decide to add a mouse section perhaps put it far down the list.

Strange, I thought you had implemented both versions of box:

https://github.com/gaocegege/Processing.R/blob/abec5d7a832ad05260eb7256c6a2ab514e3283b7/src/rprocessing/applet/BuiltinApplet.java#L213

@gaocegege
Copy link
Member Author

Oh, I forgot that. 🤔 Thanks for your review.

@gaocegege
Copy link
Member Author

Yeah, I will remove cursor from the list.

@gaocegege
Copy link
Member Author

Now renjin supports float correctly, so no need to do this work manually.

@jeremydouglass
Copy link
Member

Fastastic! Great ask, hooray for the Renjin core developers, and hooray for open source.

...and that should simplify hundreds of super calls.

@gaocegege
Copy link
Member Author

See bedatadriven/renjin#319

Now I think we could close the issue 🎉

@jeremydouglass
Copy link
Member

So at this point every method from the API is automatically inherited? And the only remaining issue is with variables -- width, height, frameCount, frameRate, looping, focused, etc?

@gaocegege
Copy link
Member Author

Yes, I think so 🤔

@jeremydouglass
Copy link
Member

jeremydouglass commented Jun 3, 2017

Since this is closed, is there a separate, open issue for variables -- width, height, frameCount, frameRate, looping, focused etc.? They are currently listed on this closed issue, but not resolved.

Perhaps edit the issue and remove them from the list, and add them to a separate issue for "Built-in variables" (vs. built-in functions).

@jeremydouglass
Copy link
Member

jeremydouglass commented Jun 3, 2017

Similarly, "Creating & Reading" is listed in the issue as "Blocked until #9" -- if this is still true then create another separate issue for Creating and Reading built-ins and delete them from this closed issue built-ins list.

@gaocegege
Copy link
Member Author

gaocegege commented Jun 3, 2017

Thanks, I forget it.

ref #81 and #86

@jeremydouglass
Copy link
Member

jeremydouglass commented Aug 20, 2017

Let's clean up this old list. Can all the "blocked until 9" boxes be checked off now that #86 is closed?

@gaocegege
Copy link
Member Author

All the functions in the list are supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment