*: Support libraries in cli runner #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ce Gao <ce.gao@outlook.com>
|
I tested this and it worked with the default PeasyCam example: Currently the only instructions on how to use the CLI are in compilation.md. https://github.com/gaocegege/Processing.R/blob/master/raw-docs/devel/compilation.md Is the Runner included with the release, and if so should use-instructions be included in the top-level documentation? |
|
Yeah, it is a good idea. But IMO the runner is not a common way for users. It is just an early way to have a test on Processing.R. |
| return new File(home + "/sketchbook/libraries"); | ||
| } else if (Platform.isWindows()) { | ||
| String home = System.getProperty("user.home"); | ||
| return new File(home + "\\Documents\\Processing\\modes"); |
There was a problem hiding this comment.
modes? Shouldn't this be libraries?
There was a problem hiding this comment.
It is a typo. Thanks for your review 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #58
Signed-off-by: Ce Gao ce.gao@outlook.com