Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coala: Add coala support #67

Merged
merged 2 commits into from
May 19, 2017
Merged

coala: Add coala support #67

merged 2 commits into from
May 19, 2017

Conversation

gaocegege
Copy link
Member

Closes #52
Ref coala/coala-bears#1750

Signed-off-by: Ce Gao ce.gao@outlook.com

Ref coala/coala-bears#1750

Signed-off-by: Ce Gao <ce.gao@outlook.com>
@gaocegege
Copy link
Member Author

coala is a perfect tool to lint and format the code in command line. But it seems that there is something wrong. I will comment the checkstyle bear now and uncomment it until the bug is fixed.

Signed-off-by: Ce Gao <ce.gao@outlook.com>
@gaocegege gaocegege merged commit c64a66f into master May 19, 2017
@gaocegege gaocegege deleted the code-style/coala branch May 19, 2017 12:59
@jeremydouglass
Copy link
Member

Excellent! Good use of coala to clean up the example sketches.

Please create an Issue for the checkstyle bear issue that references the appropriate commit line.

Please clarify what "add coala support" means -- give a bit more detail here and in the log file. For example, it could mean support for running coala manually against the repo, or support for Travis-ci integration of coala, or support for invoking coala from PDE. This will help non-core developers understand how they could use coala with Processing.R

@gaocegege
Copy link
Member Author

#67 has been filed :) And I have added the introduction in #68 , I think it is better to add the detail into the documentation 🤔

WDYT

@jeremydouglass
Copy link
Member

jeremydouglass commented May 19, 2017

Good -- yes, I agree with you that the Coding Style section is the best place for it.

Good inclusion of references, e.g. to FormatR. Is the coala add.r module (bear) based on FormatR, and/or is it designed to follow the same rules?

@gaocegege
Copy link
Member Author

Yes, the FormatRBear uses formatR as the backend.

FormatRBear

Check and correct formatting of R Code using known formatR utility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants