Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sketches to a collection #1115

Closed
andrewn opened this issue Jul 8, 2019 · 4 comments
Closed

Add sketches to a collection #1115

andrewn opened this issue Jul 8, 2019 · 4 comments

Comments

@andrewn
Copy link
Member

andrewn commented Jul 8, 2019

Nature of issue?

  • New feature request

New feature details:

This issue merges #43, #1068 as I think that an initial implementation of Collections should allow a user to add anyone's sketches into their Collections.

Collection

Collections have the following properties:

  • id (a shortid, like projects)
  • name
  • description
  • slug (for easily shareable URLs)
  • owner
  • items (a list of collected sketches)
Features
  1. A user can create a new collection
  2. A user can edit their collections' name, description and slug
  3. A user can delete their own collections'
  4. A user can see their own collections
  5. A user can see another user's collection (by their username)
  6. A user can add and remove any sketch to their own collections
  7. Collections can be sorted by:
    • name
    • date sketch was added
    • date sketch was created
    • date sketch was last updated
    • sketch owner's username
  8. Deleting a sketch that is in a collection removes it from all collections
  9. Changing a slug changes the URL the collection is available at, and the old slug URL will not longer work
Out of scope
  • Submitting a sketch to another user's collection
  • Displaying sketches as a thumbnail in a grid view
@andrewn
Copy link
Member Author

andrewn commented Jul 8, 2019

@catarak If you're ok with this, I'll close #43 and #1068 in favour of this issue.

@catarak
Copy link
Member

catarak commented Jul 10, 2019

thanks for making this issue! i do think that users being able to submit/add sketches to a collection that is not theirs is important, the use case being a classroom/assignment setting. there's obviously a totally new design here, but maybe that's something i can work on.

@andrewn
Copy link
Member Author

andrewn commented Jul 10, 2019

Totally agree with you @catarak. I've opened #1117 to capture this.

@catarak
Copy link
Member

catarak commented Mar 30, 2020

fixed by #1340.

@catarak catarak closed this as completed Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
All Projects
Collections
Development

No branches or pull requests

2 participants