Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃挕 What Do I Need to Know About My Issue Or Pull Request? 馃挕 #2534

Open
raclim opened this issue Oct 24, 2023 · 12 comments
Open

馃挕 What Do I Need to Know About My Issue Or Pull Request? 馃挕 #2534

raclim opened this issue Oct 24, 2023 · 12 comments

Comments

@raclim
Copy link
Collaborator

raclim commented Oct 24, 2023

How Do I Know My Pull Request is Getting Reviewed?

To see some of the pull requests and issues that are currently being reviewed, check the PR Review Board or the following Milestones: MINOR Release.

Issues and Pull Requests categorized under the PATCH or MINOR Release Milestones will be prioritized since they are planned to be merged for the next release to Production. Please feel free to comment down below if you would like your pull request or issue to be considered by a maintainer for one of those milestones.

Pull Requests submitted before 10/24 without a linked issue will still be reviewed, but any incoming ones after this date must be linked to an issue.

The p5.js Editor is maintained mostly by volunteers, so we thank you for your patience as we try to address your input as soon as we can.

When Will the Next Production Release Be?

We will aim to deploy on a 1-2 month basis. Here are some dates we鈥檙e working towards:

2.12.0 MINOR Release: By February 27, 2024

You can read more about Semantic Versioning and the differences between a MINOR and PATCH release.

What Does the Current Develop Branch Look Like?

Sometimes, changes might be merged into the develop branch that won't be visible on Production for a while. To see the current state of the develop branch without running this repository locally, you can view this Release build, which should be kept up to date as pull requests are merged in.

What Issues Can I Work On?

Feel free to get started on issues that already exist in this repository! For contributors looking for a place to start, we recommend focusing on issues that have already been reviewed by the maintainers and community (which can be determined by reading the issue's discussion thread) or have the "bug" label. It's not required to be assigned an issue to work on one, but a maintainer can do so on request.

What Happens After I Submit a Pull Request or Issue?

Maintainers have the ability to veto proposals. This can happen when a proposal doesn't align with the mission/community guidelines, or when a proposal presents a significant maintenance or implementation challenge that the project is not able to tackle at that time.

To propose a change, open an issue. If it is a large change or a change that necessitates significant design consideration, add a 'discussion' label to the issue. Interested community members will chime in with their thoughts. After a significant period has passed (30 days unless urgent), maintainers will try to discern whether there is significant interest and whether consensus has been reached about the best approach. At this point, maintainers will either request a vote, close the issue, or open up the issue for pull requests. Pull requests submitted before a discussion has concluded will be ignored.

We also have issues and pull requests that we closed for now but may potentially revisit for discussion in the future in saved in this board.

Please feel free to note any other suggestions or concerns with the information above, thanks!

References for Contribution

Code of Conduct

p5.js Community Statement

Contribution Guidelines for p5.js

Contribution Guidelines for the p5.js Web Editor

@raclim raclim pinned this issue Oct 24, 2023
@raclim raclim changed the title What Do I Need to Know About My Issue Or Pull Request? 馃挕 What Do I Need to Know About My Issue Or Pull Request? 馃挕 Oct 24, 2023
@perminder-17
Copy link
Contributor

perminder-17 commented Oct 25, 2023

@lindapaiste and @raclim I want my issue to be considered for next production, if possible you may add these #2466 #2446 #2483 #2511

@skbhagat0502
Copy link

#2492

@raclim
Copy link
Collaborator Author

raclim commented Oct 27, 2023

Thanks for your input @perminder-17 @skbhagat0502! For now, I added PRs: #2466, #2483, and #2511 to the next Minor Release Milestone since they fix issues or are smaller enhancements!

I think #2446 and #2492 are features that might require some more thought and discussion, but would definitely be down to think about them further! I guess I personally would like to be cautious towards adding features/interactions to the editor to ensure that they align with our commitment to access and don't affect its lack of complexity.

I'm wondering since I don't have this particular perspective, @dcarroll242 (or anyone else!) if you had any thoughts about these two features in the classroom setting?

@perminder-17
Copy link
Contributor

Thankyou @raclim for adding these issues.

@Karanpal97
Copy link

i have raise the PR for #2358 kindly see, i want my PR to be considered for next production,

@raclim
Copy link
Collaborator Author

raclim commented Oct 30, 2023

@Karanpal97 Thanks for your work and for letting us know!

I think there's currently around 7 PRs that try to resolve the issue you're working on (converting a Searchbar to a Functional Component), so it might be hard to determine which one would work best for it yet. It might take a while but we're currently still looking through them, and will definitely let you know when there's an update!

@perminder-17
Copy link
Contributor

Hi @raclim and @lindapaiste I want issue #2576 (a high priority issue) to be considered for next production.

@perminder-17
Copy link
Contributor

Hi @raclim and @lindapaiste I want issue #2576 (a high priority issue) to be considered for next production.

any updates on this issue @raclim ?

@raclim
Copy link
Collaborator Author

raclim commented Nov 10, 2023

@perminder-17 Seems like it was merged in, so it should be going in the next production release!

@perminder-17
Copy link
Contributor

@perminder-17 Seems like it was merged in, so it should be going in the next production release!

Okay nice. Thankyou.

@umangutkarsh
Copy link
Contributor

Maintainers, Please consider the following PRs. Kindly take out your time and review these.
Thank you.

#2704 , #2697 , #2696 , #2695 , #2691 .

@RAHULDAS6009
Copy link

@lindapaiste and @raclim can you see my issue #3136 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants