keyPressed event: upper and lower case #536

[iamutkarshtiwari]

This patch is a fix to the issues -> #536

With this patch, the 'keyPressed()' function will display all the letters(both upper & lower case) with their respective keyCodes(both 65-90 & 97-122) depending the On/Off status of CapLock and Shift keys. :)

[lmccart]

thanks!

[lmccart]

I'm sorry, I had to revert this PR as it was causing the key to be undefined inside keyPressed(). would you like to take another look and resubmit with an updated patch? thanks!

[iamutkarshtiwari]

@lmccart Could you please elaborate the problem which you are facing with this patch so that I can re-modify it ? A screenshot would be helpful. :)

[iamutkarshtiwari]

@lmccart I re-tested the above PR but couldn't find the problem you mentioned. Could you please share the code you tested it with?

[lmccart]

@iamutkarshtiwari sorry for the delay on this, I will post tomorrow!

[lmccart]

hi @iamutkarshtiwari, apologies again for the delay...
here's the example code I'm testing with:

function setup() {
  createCanvas(800, 800);
}

function keyPressed() {
  console.log('keyPressed key:'+key+' keyCod:'+keyCode);
}

function keyTyped() {
  console.log('keyTyped key:'+key+' keyCod:'+keyCode);
}

function keyReleased() {
  console.log('keyReleased key:'+key+' keyCod:'+keyCode);
}

when I use the keyboard.js file from this PR, this is the output in the console:

in comparison, when I use the current keyboard.js file in the p5.js repo, I see this output:

so it seems that inside keyPressed(), the key is not assigned yet, which I imagine would be a point of confusion as a lot of people create sketches based on testing the key inside keyPressed().

[iamutkarshtiwari]

There seems to be some problem with chrome because when I tested this patch on firefox, it worked perfectly fine. Looking into this.