Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of trig functions and tests #172

Merged
merged 6 commits into from
Apr 3, 2014
Merged

Conversation

shiffman
Copy link
Member

@shiffman shiffman commented Apr 2, 2014

I made a lot of changes in connection with issue #163 and always having degrees() and radians() do the conversion. Also since all the "arc" or "inverse" trig functions return an angle I am applying the conversion to degrees/radians after the fact and not on the arguments passed into the functions. I believe this is correct but @kenamarit and @antiboredom, please feel free to check this over! I also reworked all of the tests and am concerned I may have missed something.

@shiffman
Copy link
Member Author

shiffman commented Apr 2, 2014

There's also a leftover update to the JSDocs for PVector in this pull request.

* @param {x} x component (or PVector or array of 3 numbers)
* @param {y} y component
* @param {z} z component
* @param {number} x component (or PVector or array of 3 numbers)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The JavaScript type 'Number' is capitalized, I can update these

evhan55 added a commit that referenced this pull request Apr 3, 2014
Refactor of trig functions and tests
@evhan55 evhan55 merged commit 7b25348 into processing:master Apr 3, 2014
@evhan55
Copy link
Contributor

evhan55 commented Apr 3, 2014

wooh! thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants