Refactor of trig functions and tests #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ork, also unit tests
|
There's also a leftover update to the JSDocs for PVector in this pull request. |
| * @param {x} x component (or PVector or array of 3 numbers) | ||
| * @param {y} y component | ||
| * @param {z} z component | ||
| * @param {number} x component (or PVector or array of 3 numbers) |
There was a problem hiding this comment.
The JavaScript type 'Number' is capitalized, I can update these
evhan55
added a commit
that referenced
this pull request
Apr 3, 2014
Refactor of trig functions and tests
|
wooh! thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a lot of changes in connection with issue #163 and always having
degrees()andradians()do the conversion. Also since all the "arc" or "inverse" trig functions return an angle I am applying the conversion to degrees/radians after the fact and not on the arguments passed into the functions. I believe this is correct but @kenamarit and @antiboredom, please feel free to check this over! I also reworked all of the tests and am concerned I may have missed something.